Skip to content

Add Release Notes entry to the settings menu#3005

Merged
sawka merged 2 commits intomainfrom
copilot/add-release-notes-to-settings
Mar 7, 2026
Merged

Add Release Notes entry to the settings menu#3005
sawka merged 2 commits intomainfrom
copilot/add-release-notes-to-settings

Conversation

Copy link
Contributor

Copilot AI commented Mar 7, 2026

This adds a Release Notes action to SettingsFloatingWindow in the requested position: after Secrets and before Help. It also wires that action to open the existing onboarding-upgrade-patch.tsx UI as a standalone modal, so release notes remain accessible even when automatic upgrade onboarding would not render for up-to-date clients.

  • Settings menu

    • Adds a new Release Notes item to frontend/app/workspace/widgets.tsx
    • Places it between Secrets and Help
    • Uses the existing modal system rather than creating a new view/block path
  • Release notes launch path

    • Registers UpgradeOnboardingPatch in the modal registry
    • Opens it from the settings menu via modalsModel.pushModal("UpgradeOnboardingPatch", { isReleaseNotes: true })
  • Standalone modal behavior

    • Extends UpgradeOnboardingPatch with a lightweight isReleaseNotes mode
    • In release-notes mode, closing the modal pops the stacked modal instead of toggling upgradeOnboardingOpen
    • Preserves the existing automatic upgrade-onboarding flow and version metadata update behavior for the original path
{
    icon: "book-open",
    label: "Release Notes",
    onClick: () => {
        modalsModel.pushModal("UpgradeOnboardingPatch", { isReleaseNotes: true });
        onClose();
    },
}
    • Release notes modal content:
      Release Notes modal

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 7, 2026

Deploying waveterm with  Cloudflare Pages  Cloudflare Pages

Latest commit: 411bef1
Status: ✅  Deploy successful!
Preview URL: https://cf355430.waveterm.pages.dev
Branch Preview URL: https://copilot-add-release-notes-to.waveterm.pages.dev

View logs

Copilot AI changed the title [WIP] Add Release Notes item to SettingsFloatingWindow Add Release Notes entry to the settings menu Mar 7, 2026
Copilot finished work on behalf of sawka March 7, 2026 01:06
@sawka sawka marked this pull request as ready for review March 7, 2026 01:13
@kilo-code-bot
Copy link
Contributor

kilo-code-bot bot commented Mar 7, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (3 files)
  • frontend/app/modals/modalregistry.tsx - Added modal registration
  • frontend/app/onboarding/onboarding-upgrade-patch.tsx - Added isReleaseNotes prop and conditional close logic
  • frontend/app/workspace/widgets.tsx - Added Release Notes menu item

The PR adds a "Release Notes" menu item to the Settings floating window that reuses the existing UpgradeOnboardingPatch modal component with a new isReleaseNotes prop. The implementation correctly:

  1. Differentiates between release notes mode and upgrade onboarding mode
  2. Uses modalsModel.popModal() for release notes (modal stack) vs upgradeOnboardingOpen atom for onboarding
  3. Skips metadata updates when viewing release notes (intentional - prevents marking onboarding as complete)

No bugs, security issues, or runtime errors identified.

@sawka sawka merged commit 46593b9 into main Mar 7, 2026
7 checks passed
@sawka sawka deleted the copilot/add-release-notes-to-settings branch March 7, 2026 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants